src/plugin/auth.test.ts (1)

25-33: LGTM — regression tests correctly cover both null-safety requirements from the issue.

Minor nit: each test calls isOAuthAuth twice. Since the function is pure, the not.toThrow() assertion is implicitly covered by the toBe(false) assertion that follows (a thrown error would itself fail the test). You could consolidate to a single assertion per test, but the explicit form is acceptable given the issue explicitly requested verifying "does not throw."

♻️ Optional consolidation (two assertions → one per test)

-  it("returns false for undefined auth without throwing", () => {
-    expect(() => isOAuthAuth(undefined)).not.toThrow();
-    expect(isOAuthAuth(undefined)).toBe(false);
-  });
-
-  it("returns false for null auth without throwing", () => {
-    expect(() => isOAuthAuth(null)).not.toThrow();
-    expect(isOAuthAuth(null)).toBe(false);
-  });
+  it("returns false for undefined auth without throwing", () => {
+    expect(isOAuthAuth(undefined)).toBe(false);
+  });
+
+  it("returns false for null auth without throwing", () => {
+    expect(isOAuthAuth(null)).toBe(false);
+  });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/plugin/auth.test.ts` around lines 25 - 33, The two tests in auth.test.ts
redundantly call isOAuthAuth twice (once inside expect(...).not.toThrow() and
once for expect(...).toBe(false)); since isOAuthAuth is pure a thrown error
would already fail the test, consolidate each test to a single assertion by
removing the not.toThrow() check and only assert
expect(isOAuthAuth(undefined)).toBe(false) and
expect(isOAuthAuth(null)).toBe(false) respectively, keeping the same test names
and the isOAuthAuth references so the intent remains clear.

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting